Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unsafe HTML construction with createIcon #446

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

stepankuzmin
Copy link
Contributor

This PR removes IE support for icon creation and removes createIcon from the MapboxGeocoder prototype.

Copy link

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I understand the rationale for removing createIcon from index.js, but this does technically change the API. It's not a documented method, but I think removing it might still necessitate a major version change, so maybe it's better to leave it be.

@stepankuzmin
Copy link
Contributor Author

Thanks Ryan!

As per discussion with @mapbox-danny we can hold on the merge until a major version update

@ryanhamley
Copy link

@stepankuzmin I think it's ok to revert the change that removes createIcon from the public API and just remove the offending IE11 code. That will resolve the open security ticket.

@stepankuzmin stepankuzmin force-pushed the fix-unsafe-HTML-construction branch from 14216fe to 35be171 Compare January 7, 2022 12:53
@stepankuzmin
Copy link
Contributor Author

@ryanhamley sure, I've updated the PR

Copy link
Contributor

@mapbox-danny mapbox-danny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the Promise.resolve fix too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants