No hardcoded ids #217
Merged
No hardcoded ids #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katydecorah
reviewed
Mar 18, 2019
Co-Authored-By: scottsfarley93 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapbox geocoder does not guarantee stability of the
idproperty on returned feature. In order to ensure that the exceptions are applied even if the underlying IDs change, this PR changes the bounding box exceptions checking to use theproperties.short_codeon returned features, which specifies a ISO 3166-1 country code which provides a more stable identifier to check against.masterheading before merging\cc @katydecorah @yuletide