Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Zstandard streaming decompression #47

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Implement Zstandard streaming decompression #47

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9335283
Initial attempt at implementing Zstandard streaming decompression
mkitti Aug 9, 2024
d5866e1
Drop Node 16 due to exeptions support, bump setup-node to v4
mkitti Aug 10, 2024
a448b7b
Add streaming decompression tests for streaming compression
mkitti Aug 10, 2024
5b0ccab
Apply prettier
mkitti Aug 10, 2024
89f6854
Add EXPORT_EXCEPTION_HANDLING_HELPERS
mkitti Aug 10, 2024
cdbe1d9
Code clean up
mkitti Aug 10, 2024
c0015b8
Fix typo in build.sh
mkitti Aug 11, 2024
d3b1e01
Free decompression stream when throwing or exiting
mkitti Aug 11, 2024
c15341f
Throw error if there is additional input data after decompressing frame
mkitti Aug 12, 2024
d4da095
Run prettier on test/zstd.test.js
mkitti Aug 12, 2024
b4714df
Update with recommendations from Janelia SciCompSoft code review
mkitti Aug 14, 2024
6b8c5ed
Update codecs/zstd/zstd_codec.cpp
mkitti Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codecs/zstd/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ cd ../../../
${OPTIMIZE} \
-I "$CODEC_DIR/lib" \
--closure 1 \
-fwasm-exceptions
-fwasm-exceptions \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see you did use wasm exceptions!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is listed as "legacy" now, but the alternative proposal isn't supported in any runtimme at all so I'm good with using for now: https://webassembly.org/features/

-s ALLOW_MEMORY_GROWTH=1 \
-s MODULARIZE=1 \
-s EXPORT_ES6=1 \
Expand Down
Loading