-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in Rhai Event Handler #76
Conversation
I just noticed that i also updated the Rhai version. please tell me if I should revert this change or not. |
I also just changed it so that i no longer get errors printed out when a function can't be found in a script. as far as i can tell, this is a similar behaviour as in the Lua solution: bevy_mod_scripting/languages/bevy_mod_scripting_lua/src/lib.rs Lines 169 to 172 in 7590248
|
Hi @zwazel PR looks good, great catch! Love the examples. Please see to the clippy errors and LGTM |
Glad I can help with this great crate!
Just saw your comment on it, will Look at it later. On mobile right now. |
Appreciate it a lot! no problem! |
Hi, as far as I can tell the only clippy warning that I got was from lua derive. |
Yeah sorry about that, the CI runs on latest rust version meaning any new clippy warnings randomly popup on old code, I need to find a way to pick the clippy version somehow |
This should fix #75
Also added a new example for Rhai.