Update routing example #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
reviewed
Dec 1, 2020
|
Can you open an issue for that bug? It's indeed a bit strange… |
patsy-issa
force-pushed
the
update-routing-example
branch
from
4069e57 to
0035c10
Compare
|
Added a basic acceptance test and opened #364 to keep track of the bug |
marcoow
approved these changes
Dec 1, 2020
marcoow
pushed a commit
that referenced
this pull request
Dec 2, 2020
* update ember dependencies * run class codemod * update to current idioms * move artificial delay to config * add basic functionality acceptance test
marcoow
pushed a commit
that referenced
this pull request
Dec 2, 2020
* update ember dependencies * run class codemod * update to current idioms * move artificial delay to config * add basic functionality acceptance test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed a bug that is also present in master, if you navigate to media -> movies and then select a movie for a brief moment the query param value seems to revert to the default value,
filter = "albums";in this case, and then back to the correctly filtered list.Would like to revisit this once the remaining example repos have been updated.