ember-cli-addon - split initializer

[Jakeii]

Hopefully this should be the last of the initializer pulls! Targets the ember-cli-addon branch.

As per emberjs/ember.js#10256 (comment), it no longer relies on deferRediness, and incorporates most of the setup into the ApplicationRouteMixin.beforeModel method.

The initializer now only registers the stores/session, and instanceInitializer now only injects session into components, controllers, routes.

[marcoow]

Is this still necessary then?

[Jakeii]

Good point, no need to check if listeners are assigned as ApplicationRoute.beforeModel is only called once per page load.

[Jakeii]

The ApplicationRouteMixin could be deprecated in favour of using reopen in the instance initializer to start setup and add the actions.

[marcoow]

It would definitely be cool to deprecate the ApplicationRouteMixin but I don't think making reopen the "official" way to get along without it is great - there should be a cleaner solution.

[Jakeii]

Whats wrong with reopen? it's not a hack, it's used internally within Ember and referenced in the official guide and API docs.

[marcoow]

It's basically the same as monkey patching in Ruby - it's very powerful and makes a lot of things very simple in the first place. At the same time though if used heavily it complicates stuff as you might be looking at some method that might be overridden somewhere else and then you wonder why it doesn't behave the way it should by looking at the original source code.