New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(all): use on modifier. Action template helper dropped in 6.0 #2876

Merged

BobrImperator merged 2 commits into master from use-on-modifier

Dec 25, 2024

Collaborator

BobrImperator commented Dec 25, 2024

Removes instances of {{action template helper in favor of {{on
Removes actions hash in classic-test-app and uses action decorator i.e. import { action } from '@ember/object'

Action template helper is dropped in Ember 6.0.

BobrImperator added 2 commits

December 25, 2024 02:17


          refactor(all): use on modifier. action dropped in 6.0

10c3ba6


          refactor(classic-test-app): remove actions hash, import action from @…

1eab153

…ember/object

BobrImperator added the internal label

github-actions bot commented Dec 25, 2024 •

edited

Loading

Some tests with 'continue-on-error: true' have failed:

test-app test:one ember-beta
test-esa test:one ember-canary
classic-test-app test:one ember-canary
test-esa test:one ember-beta
test-app test:one ember-canary

Created by continue-on-error-comment

BobrImperator merged commit 3eeb974 into master

41 of 44 checks passed

BobrImperator deleted the use-on-modifier branch

December 25, 2024 01:53

github-actions bot mentioned this pull request

Prepare Release #2821

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels