Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): Migrate eslint config #2804

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Conversation

BobrImperator
Copy link
Collaborator

  • Migrates eslint config to the new syntax
  • Unifies configs so they're defined only once and imported where needed
  • Applies autofixes
  • Turned off the 'no-prototype-builtins' rule.

@BobrImperator BobrImperator added the dependencies Pull requests that update a dependency file label Jul 7, 2024
@BobrImperator BobrImperator force-pushed the migrate-eslint-config branch 2 times, most recently from 0c4fcb5 to 6812ca3 Compare July 7, 2024 11:38
@BobrImperator BobrImperator requested a review from marcoow July 7, 2024 11:42
@BobrImperator BobrImperator force-pushed the migrate-eslint-config branch from 6812ca3 to 85a53ee Compare July 7, 2024 12:40
Copy link

github-actions bot commented Jul 7, 2024

Some tests with 'continue-on-error: true' have failed:

  • test-esa test:one ember-beta

  • test-app test:one ember-beta

  • test-app test:one ember-canary

  • classic-test-app test:one ember-beta

  • test-esa test:one ember-canary

    Created by continue-on-error-comment

Copy link

github-actions bot commented Jul 7, 2024

Some tests with 'continue-on-error: true' have failed:

  • classic-test-app test:one ember-canary

Created by continue-on-error-comment

@BobrImperator
Copy link
Collaborator Author

@marcoow they were there in the original file, I don't think we'd like to address them here?

This PR only addresses config migration and formatting that was somehow not applied for other files.
e.g. inconsitencies around spacing and "" -> '' conversion.

@marcoow
Copy link
Member

marcoow commented Jul 8, 2024

ah I see

@BobrImperator BobrImperator merged commit 189b35d into master Jul 8, 2024
39 of 42 checks passed
@BobrImperator BobrImperator deleted the migrate-eslint-config branch July 8, 2024 06:46
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants