-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge getBH_dict into getBH #449
Merged
Merged
+237
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #449 +/- ##
============================================
Coverage 99.75% 99.75%
============================================
Files 49 49
Lines 4883 4888 +5
============================================
+ Hits 4871 4876 +5
Misses 12 12
Continue to review full report at Codecov.
|
…to combine_getB
…to combine_getB
…to combine_getB
OrtnerMichael
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to merge the functionality of the
getB_dict
andgetH_dict
intogetB
andgetH
respectively, in order to make the top level interface less cluttered. This introduces some minor breaking changes by removinggetB_dict
andgetH_dict
functions from the library top level. These library can still be accessed privately, as they remain unchanged internally.The original
getB
andgetH
function remain unchanged in their classical use.Before
After
Note
providing
kwargs
when the source is not a string will raise an errorTODO