Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: No peaks detected in not-blacklisted regions when a blacklist is given to macs3 hmmratac #680

Open
MariaRig opened this issue Dec 5, 2024 · 2 comments
Assignees

Comments

@MariaRig
Copy link

MariaRig commented Dec 5, 2024

Hi,
I have run macs3 hmmratac with and without a blacklist and I have realised that even small blacklisted regions (~1kb long can lead to huge gaps in the peak calling, but only in some samples. Not giving the black list fixed the issue.

These gaps seem more frequent in samples with worse signal-to-noise ratio, but the peak calling is overall very good except for the gaps.

Also, hmmratac was run on bams already filtered for the blacklisted regions, so it was probably unnecessary to run it with the black list, but I thought you would want to know that this can happen.

Kind regards

Screenshot 2024-12-05 at 11 36 24

@taoliu
Copy link
Contributor

taoliu commented Feb 5, 2025

Thanks! These peaks were possibly incorrectly removed when the 'candidate region' for Hidden Markov Model decoding overlaps just a tiny bit of the 'blacklisted' region. Let me think how to change this behavior. Agree that we may just need to remove the reads from alignment file in the beginning of the whole process.

@taoliu taoliu self-assigned this Feb 5, 2025
taoliu added a commit that referenced this issue Feb 12, 2025
… utilized after reading alignments #680; 3. rename  to  for ; 4. update docs
@taoliu
Copy link
Contributor

taoliu commented Feb 12, 2025

Re-implement the feature to exclude reads located in blacklisted regions before EM and HMM steps. 5b08668

Will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants