Update sort and filter fields for device inventory endpoints #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.jamf.com/jamf-pro/reference/get_v1-computers-inventory
https://developer.jamf.com/jamf-pro/reference/get_v2-mobile-devices-detail
As on the 🥫In some cases allowed fields had not been correctly copy/pasted since Jamf's developer docs aren't friendly to grok. Fixed those list items which were not comma separated correctly. Added new fields which have likely been added recently. Where fields were added I did test with the API to ensure they returned objects as expected. I found this when trying to query for devices by
managementIdand getting aValueError