Simplify makefiles #169
Merged
Simplify makefiles #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make already has a dry run option (`-n`) that prints commands instead of executing them. It isn't compatible with these `ifeq` blocks and I don't really see the benefit of the duplication of "if not dry run exec command else print command".
Using carriage returns is okay interactively and when things are going well. But it also goes wrong; entire lines usually disappear from build logs, and in some circumstances I see run-on messages like this: ``` Building C++ source file common.cppBuilding C++ source file memory.cppBuilding C++ source file affinity.cppBuilding C++ source file cuda.cppBuilding C++ sourc e file ring.cppBuilding C++ source file ring_impl.cppBuilding C++ source file a rray.cppBuilding C++ source file unpack.cppBuilding C++ source file quantize.cp pBuilding C++ source file proclog.cppBuilding C++ source file address.cppIn fil e included from address.cpp:30: ``` Cleaner looking status messages in one context is not worth the trouble in other contexts, IMO.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 58.54% 58.54%
=======================================
Files 67 67
Lines 5727 5727
=======================================
Hits 3353 3353
Misses 2374 2374 Continue to review full report at Codecov.
|
|
I like it. |
league
added a commit
to league/bifrost
that referenced
this pull request
Mar 28, 2022
Following merge of PR lwa-project#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the
DRY_RUNdistinction in makefiles (make -nworks better) and quit trying to use carriage returns\rin makefile output. Please see commit messages for more rationale!