Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Monitor for OracleDB #2796

Closed
wants to merge 1 commit into from
Closed

New Monitor for OracleDB #2796

wants to merge 1 commit into from

Conversation

bitsky6
Copy link

@bitsky6 bitsky6 commented Feb 17, 2023

add oracledb

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #(issue)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

add oracledb
@bitsky6
Copy link
Author

bitsky6 commented Feb 17, 2023

Added oracledb for monitoring.

@Computroniks
Copy link
Contributor

I think you might have forgotten to commit a file, only 8 lines are changed and there is a reference to an undefined function, could you also fix the linting issues

@louislam louislam marked this pull request as draft February 17, 2023 18:35
@louislam
Copy link
Owner

You meant to add a new montior for oracle database right? Please change the title.

It seems that it is not ready yet. I changed to draft first. Please press Ready for review once it is ready.

@bitsky6 bitsky6 changed the title Update monitor.js New Monitor for OracleDB Feb 17, 2023
@bitsky6 bitsky6 closed this Feb 17, 2023
@bitsky6
Copy link
Author

bitsky6 commented Feb 17, 2023

I have made another as did it over VScode somehow couldnt edit here so closed it.
I have opened another pushed with VS code.
Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants