Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker sock path #2379

Closed
wants to merge 2 commits into from
Closed

Conversation

ryck
Copy link

@ryck ryck commented Dec 8, 2022

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Very small PR to change the docker.sock default, as it confuse me today when I try to setup docker notifications

Another way to fix it (and maybe a better one) would be to find out why /var/run/docker.sock is not valid (probably a permissions issue) so feel free to decline this PR

This also needs an small change in the wiki (I did another tiny PR for that too)

Fixes #(issue)
#2061

Type of change

  • User interface (UI)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • My changes generate no new warnings

Screenshots (if any)

image

@louislam
Copy link
Owner

louislam commented Dec 9, 2022

Uptime Kuma is not a Docker only application. In non-Docker context, it is not a correct path to the docker.sock.

Also, applications such as Portainer and Swarmpit are also using /var/run/docker.sock by default.

docker run -d -p 8000:8000 -p 9443:9443 --name portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ce:latest
docker run -it --rm \
  --name swarmpit-installer \
  --volume /var/run/docker.sock:/var/run/docker.sock \
swarmpit/install:1.9

@ryck
Copy link
Author

ryck commented Dec 9, 2022

Fair enough! As I said, probably looking into why the standard path doesn't work is a better option.

Thanks for all your hard work!

@ryck ryck closed this Dec 9, 2022
@louislam
Copy link
Owner

louislam commented Dec 9, 2022

Fair enough! As I said, probably looking into why the standard path doesn't work is a better option.

Thanks for all your hard work!

Yes, the hardest part of such issues is that it is not always reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants