Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create monitor-docker-container #15

Closed
wants to merge 1 commit into from
Closed

Conversation

Meulator
Copy link

Added link to original thread louislam/uptime-kuma#2061

@louislam
Copy link
Owner

Ops, I already added it 5 hours ago, but I forgot to sync to this repo. Thanks anyway.

https://github.com/louislam/uptime-kuma/wiki/How-to-Monitor-Docker-Containers

@ThelloD
Copy link

ThelloD commented Sep 15, 2022

Ops, I already added it 5 hours ago, but I forgot to sync to this repo. Thanks anyway.

https://github.com/louislam/uptime-kuma/wiki/How-to-Monitor-Docker-Containers

Please add a warning regarding the security risks of sharing the docker.sock to this wiki page.

Sharing the docker.sock with Uptime Kuma container means trivial privilege escalation and container escape, affecting security of both other containers as well as the docker host! The read-only flag does not prevent this type of attack at all since the socket is not a regular file on the file system.

I've also commented regarding this issue here:
louislam/uptime-kuma#2061 (comment)

You also mention:

:ro (readonly) is recommended.

This might lead to a false understand of the security implications of sharing the docker.sock file, because as already stated, setting this flag does not really matter in this case as this is not a regular file.

If Uptime Kuma is exposed to the Internet, because of security reasons I advice against sharing the docker.sock with Uptime Kuma, even if it is a nice feature.

@louislam louislam closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants