fix test fails for request-response-samples #6
+2,341
−1,139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakrkris
force-pushed
the
request-response-test-fixes
branch
2 times, most recently
from
7aaf0a0 to
1a4e885
Compare
| @@ -79,7 +79,7 @@ class NamespaceScope { | |||
| default: | |||
| for (var p in this.namespaces) { | |||
| if (this.namespaces[p].uri === nsURI) { | |||
| return p; | |||
| return this.namespaces[p]; | |||
There was a problem hiding this comment.
Why do we return the object instead of namespace prefix as a string?
There was a problem hiding this comment.
@raymondfeng the namespace object has more details needed by the calling stack
deepakrkris
force-pushed
the
request-response-test-fixes
branch
8 times, most recently
from
13ceddb to
04f2174
Compare
| @@ -49,6 +49,8 @@ | |||
| "diff": "^2.2.3", | |||
| "doctoc": "^1.1.1", | |||
| "duplexer": "^0.1.1", | |||
| "eslint": "^3.4.0", | |||
| "eslint-config-google": "^0.6.0", | |||
There was a problem hiding this comment.
Can we use eslint-config-loopback instead?
deepakrkris
force-pushed
the
request-response-test-fixes
branch
8 times, most recently
from
63c83aa to
1376d2f
Compare
deepakrkris
force-pushed
the
request-response-test-fixes
branch
6 times, most recently
from
2ba4287 to
c3861d0
Compare
errors in test xml and wsdl files are fixed. some errors are in the code related to namespaces, prefixes, attributes
errors in test xml and wsdl files are fixed. some errors are in the code related to namespaces, prefixes, attributes
deepakrkris
force-pushed
the
request-response-test-fixes
branch
from
c3861d0 to
7ef9034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors in test xml and wsdl files are fixed. some errors are in the code
related to namespaces, prefixes, attributes