Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewer:
I'll start by saying that this is "fix" for a problem I have related to the SOAP web services I need to invoke. My main problem is that
http
(viarequest
) lowercases the header names, and the web services I invoke have a case-sensitive validation on http headers:https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L365
I could try to remove that, but I have a strong suspicion that a PR modifying that would be rejected since the HTTP standard states that the HTTP header name validation should be case insensitive:
https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html
I know those WS are not doing what's right, but I'd be surprised if I were the first one having this problem.
Thanks for reading and reviewing.