Using targetNamespace of the attribute if present #32
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@rashmihunt or @deepakrkris PTAL |
|
@bajtos I am looking into this PR |
|
@slnode test please |
1 similar comment
|
@slnode test please |
|
@Guatom Thank you for the contribution. |
|
No, thank you for reviewing! I'll think I'll be able to submit one or two more PRs to close the gaps for using the web services I need. |
raymondfeng
pushed a commit
that referenced
this pull request
Dec 16, 2016
* fixed a CI failure in downstream (rashmihunt) * updated debug statements (rashmihunt) * add prettyPrint to client options (rashmihunt) * fixed downstream failing test (rashmihunt) * fixed a testcase failure (rashmihunt) * support forcing soap version (rashmihunt) * Update tr translation file (Candy) * support correctly (rashmihunt) * Initial support for NTLM (#52) (Rashmi Hunt) * Update translation files (Candy) * removing CookieSecurity from this branch to keep PR's separate (Branden Horiuchi) * adding check for element length on outputBodyDescriptor (Branden Horiuchi) * * adding CookieSecurity to built-in security methods (Branden Horiuchi) * Add translation files (Candy) * added header to input operation (rashmihunt) * fix for #31 (rashmihunt) * Using targetNamespace of the attribute if present (#32) (Guatom)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what fixes the namespace problem for the web services I consume. I think it's the right thing to do since the targetNamespace of the schema containing the requests and responses should be used for those too (if they don't specify another one, though).