Fixed wsdl-test failure #24
Merged
+52
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Sep 30, 2016
| @@ -17,7 +17,8 @@ | |||
| "selectn": "^1.0.20", | |||
| "strong-globalize": "^2.8.0", | |||
| "xml-crypto": "^0.8.4", | |||
| "xmlbuilder": "^8.2.2" | |||
| "xmlbuilder": "^8.2.2", | |||
| "async": "~1.0.0" | |||
There was a problem hiding this comment.
We should use ^2.0.0. A simple way to add it is npm i async --save-dev.
Please make it dev dependency too.
raymondfeng
reviewed
Sep 30, 2016
| soap.createClient(__dirname + '/wsdl/strict/' + file, {strict: true}, function (err, client) { | ||
| assert.ok(!err); | ||
| client.describe(); | ||
| }); |
There was a problem hiding this comment.
You should call cb(err); here to notify async that this task is done.
raymondfeng
reviewed
Sep 30, 2016
| client.describe(); | ||
| }); | ||
| }); | ||
| done(); |
There was a problem hiding this comment.
done is called too early. You need to pass done as the last argument to async.each so that done will be called once async finishes all tasks or one of them fails.
raymondfeng
reviewed
Sep 30, 2016
| var expectedError = false; | ||
| try { | ||
| client.describe(); | ||
| } catch (err) { |
There was a problem hiding this comment.
Add done(new Error('An error should have been thrown'));.
raymondfeng
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raymondfeng PTAL