Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove and re-implement forceSoap12Headers wsdl option #22

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Remove and re-implement forceSoap12Headers wsdl option #22

merged 1 commit into from
Sep 29, 2016
+74 −59

Conversation

rashmihunt
Copy link
Contributor

  • Removed wsdl option 'forceSoap12Headers' setting. Added code to figure out if the request, response
    and fault envelope should use soap 1.1 or soap 1.2 based on the binding from the WSDL.
  • Fixed request/response/fault path.
  • Fixed tests to invoke correct operation if multiple bindings point to same operation.
  • Fixed 1.2 to show correct soap 1.2 namespace in request/response/fault.
  • Cleanup of examples with minor fixes.

@raymondfeng PTAL

raymondfeng
raymondfeng approved these changes Sep 29, 2016
View reviewed changes
Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmihunt rashmihunt merged commit 66f8a65 into master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rashmihunt @raymondfeng