Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates, cleanup of Examples & code #19

Merged
merged 11 commits into from
Sep 27, 2016
Merged

Readme updates, cleanup of Examples & code #19

merged 11 commits into from
Sep 27, 2016

Conversation

rashmihunt
Copy link
Contributor

  • Readme updates
  • Changes to Licence, Contributing files etc
  • Cleanup of Examples
  • Cleanup of code based on Readme

@raymondfeng PTAL

@@ -11,37 +11,34 @@ This module lets you connect to web services using SOAP. It also provides a ser

- [Features:](#features)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing :.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed review comments.. @raymondfeng PTAL

@raymondfeng
Copy link
Contributor

We should clean up LICENSE file with IBM copyright and MIT. Please add a NOTICE file to point out that this module contains code from soap with MIT.

@raymondfeng
Copy link
Contributor

We need to mention the ability to load/parse/process WSDL/XSD documents. Maybe add some examples.

@raymondfeng
Copy link
Contributor

LGTM

@rashmihunt rashmihunt merged commit 2eadad3 into master Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants