fix for CI build errors #16
Merged
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakrkris
force-pushed
the
fix-ci-errors
branch
12 times, most recently
from
1183300 to
5f6bd15
Compare
raymondfeng
reviewed
Sep 22, 2016
| @@ -52,7 +52,7 @@ var elementTypes = [ | |||
| './xsd/extension', | |||
| './xsd/group', | |||
| './xsd/import', | |||
| './xsd/include', | |||
| './xsd/Include', | |||
There was a problem hiding this comment.
Why this change? If the file name is wrong, we should fix it.
There was a problem hiding this comment.
@raymondfeng the file name is not wrong, it has a capital "I" ; we can either change the file name or the reference to it. If you think the standard is to have file names with small case letters, I will do that
There was a problem hiding this comment.
We should rename the file to be include.js.
There was a problem hiding this comment.
@raymondfeng done. Do I have a +1 ?
deepakrkris
force-pushed
the
fix-ci-errors
branch
2 times, most recently
from
60146ec to
ea444b4
Compare
fixes for errors in cis-jenkins
deepakrkris
force-pushed
the
fix-ci-errors
branch
from
ea444b4 to
b5f2515
Compare
|
@slnode test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors in CI builds