Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for soap 1.2 Fault and test cases #15

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Support for soap 1.2 Fault and test cases #15

merged 2 commits into from
Sep 21, 2016

Conversation

rashmihunt
Copy link
Contributor

Changes include:

  1. Code to support soap 1.2 Fault
  2. New Test case to support soap 1.2 fault
  3. Fixed Fault related existing tests
  4. All tests run 100% successfully in this module now.

@raymondfeng PTAL

Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

res.end();
});

test.server.listen(15099, null, null, function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should try to make the port number more env friendly to avoid conflicts on CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix the port number issue as part of loopbackio/loopback-connector-soap#36

@rashmihunt rashmihunt merged commit 222dd2b into master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants