Test fixes #1
Closed
Test fixes #1
+13,235
−7,655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,11 +13,17 @@ class Base extends EventEmitter { | |||
| this.bodyAttributes = []; | |||
| } | |||
|
|
|||
| addSoapHeader(value, qname, options) { | |||
| var header = new SOAPElement(value, qname, options); | |||
| addSoapHeader(name, value, qname, options) { | |||
There was a problem hiding this comment.
Why do we need to have both name and qname?
There was a problem hiding this comment.
qname existed already in soapHeader. name is added because, in client.js code was referring to soapHeader.name. I guess, we should derive the name from the qname. I will go ahead and make the changes.
…el and added checks for null and undefined
…derive operationName, outputName and fixed server-options-test to pass srapper oject in the request
…ert logic in 2 tests in client-test.js
raymondfeng
force-pushed
the
test-fixes
branch
from
f29e701 to
4f858bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.