Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: leverage event_factory support #195

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Feat: leverage event_factory support #195

merged 4 commits into from
Aug 1, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Jul 29, 2021 •
edited
Loading

also includes an unrelated test update to get the CI 🟢

kaisecheng
kaisecheng reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not having target in this plugin?

@kares
Copy link
Contributor Author

kares commented Jul 30, 2021

Thanks for looking Kaise, yes there's existing target support and the plugin does special logic already to handle re-targeting data (thus no need to use the targeted_event_factory).

kaisecheng
kaisecheng approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦩

@kares kares merged commit bce0308 into logstash-plugins:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisecheng kaisecheng kaisecheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kares @kaisecheng