Add support for multiple Markers attached to a single LoggingEvent #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILoggingEvent can have multiple markers associated with them since Logback 1.3. To support this new behavior, a new ILoggingEvent#getMarkerList() method has been introduced. This change retrieves the Marker by calling this new method instead of the former #getMarker(). Test case have been adapted consequently. Also, tests have been modified to use concrete instances of LoggingEvent instead of mocking the used methods. This way we don’t make any assumption anymore about the actual behaviour of the LoggingEvent.
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
============================================
- Coverage 70.90% 70.80% -0.11%
- Complexity 1258 1261 +3
============================================
Files 168 168
Lines 4816 4829 +13
Branches 502 505 +3
============================================
+ Hits 3415 3419 +4
- Misses 1153 1156 +3
- Partials 248 254 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brenuart
deleted the
831-add-support-for-multiple-marker-instances-on-a-single-logging-event-slf4j-200
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILoggingEvent can have multiple markers associated with them since Logback 1.3. To support this new behavior, a new ILoggingEvent#getMarkerList() method has been introduced. This change retrieves the Marker by calling this new method instead of the former #getMarker().
Test case have been adapted consequently. Also, tests have been modified to use concrete instances of LoggingEvent instead of mocking the used methods. This way we don’t make any assumption anymore about the actual behaviour of the LoggingEvent.
closes #831