Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException in the "after the last transition" case #789

Closed
wants to merge 1 commit into from
Closed

Conversation

dongockien92
Copy link

@dongockien92 dongockien92 commented Apr 11, 2022

When the timezone belong to the "after the last transition" case (ex: "Asia/Bangkok"), we'll get the NullPointerException at FastISOTimestampFormatter

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #789 (7986bd3) into main (eb692bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #789   +/-   ##
=========================================
  Coverage     70.79%   70.80%           
  Complexity     1248     1248           
=========================================
  Files           167      167           
  Lines          4784     4788    +4     
  Branches        493      494    +1     
=========================================
+ Hits           3387     3390    +3     
  Misses         1151     1151           
- Partials        246      247    +1     
Impacted Files Coverage Δ
...h/logback/composite/FastISOTimestampFormatter.java 95.45% <100.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ff53e...7986bd3. Read the comment docs.

@brenuart
Copy link
Collaborator

@dongockien92 Thanks for this report and your proposed PR.
I discovered other edge cases when reviewing your solution and decided to create another branch whose content is heavily inspired from your PR.
I'm closing your PR now without merging it - please follow #794 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants