Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFieldValue() should return fieldValue without transforming it into a String #720

Merged
merged 1 commit into from
Jan 5, 2022
+4 −4
Merged

getFieldValue() should return fieldValue without transforming it into a String #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/net/logstash/logback/marker/ObjectAppendingMarker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ protected void writeFieldValue(JsonGenerator generator) throws IOException {
}

@Override
public Object getFieldValue() {
return StructuredArguments.toString(fieldValue);
protected Object getFieldValue() {
return fieldValue;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/logstash/logback/marker/RawJsonAppendingMarker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ protected void writeFieldValue(JsonGenerator generator) throws IOException {
}

@Override
public Object getFieldValue() {
protected Object getFieldValue() {
return rawJson;
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/logstash/logback/marker/SingleFieldAppendingMarker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public String toStringSelf() {
*
* @return the field value
*/
public abstract Object getFieldValue();
protected abstract Object getFieldValue();

@Override
public boolean equals(Object obj) {
Expand Down