Gh680 jsonproviders no auto start #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring Issue #680: no auto-start of JsonProviders - remove Lifecycle from the JsonProvider interface to prevent Logstash from auto-starting the provider - declare the start/stop method initially defined by the Lifecycle interface in the JsonProvider interface - now that start() is called only once, parse the JSON string during start() Issue #679: remaining characters after reading JSON string - raise an error if some characters remain after reading a JsonNode out of the string
philsttr
reviewed
Oct 17, 2021
src/main/java/net/logstash/logback/composite/AbstractPatternJsonProvider.java
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/JsonReadingUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/JsonReadingUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/net/logstash/logback/composite/GlobalCustomFieldsJsonProviderTest.java
Show resolved
Hide resolved
philsttr
reviewed
Oct 17, 2021
| * | ||
| * @param jsonFactory the {@link JsonFactory} from which to obtain a {@link JsonParser} to read the JSON string. | ||
| * @param json the JSON string to read | ||
| * @param readFully whether to throw a {@link JsonParseException} when the input is not fully read. |
There was a problem hiding this comment.
I don't see any places in where readFully is ever false. The code and tests could be simplified a bit since that functionality is not needed. It can always be added in the future if it is ever needed.
There was a problem hiding this comment.
True... do you mean to keep only the readFully... methods ?
brenuart
force-pushed
the
main
branch
3 times, most recently
from
8e7c02d to
926c65a
Compare
These methods will be re-introduced when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #680: no auto-start of JsonProviders
Close #679: remaining characters after reading JSON string