-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch FastDateFormat to DateTimeFormatter #377
Conversation
Remove dependency on apache commons-lang3 (since FastDateFormat was the only thing being used). Switch default timestamp format to DateTimeFormatter.ISO_OFFSET_DATE_TIME Added the ability to specify DateTimeFormatter constant names as patterns. This change is NOT fully backwards compatible, since: * the default timestamp pattern changed to DateTimeFormatter.ISO_OFFSET_DATE_TIME * the pattern strings supported by DateTimeFormatter are not exactly the same as those supported by FastDateFormat
We have the problem with the randomly sorted log messages, too (if their millisecond-precision-timestamps are the same). ELK released the fix with 7.0? elastic/elasticsearch#10005 |
Hi @mfriess2 , this change to logstash-logback-encoder to switch to |
Switch usage of
FastDateFormat
toDateTimeFormatter
Remove dependency on apache commons-lang3 (since
FastDateFormat
was the only thing being used).Switch default timestamp format to
DateTimeFormatter.ISO_OFFSET_DATE_TIME
Added the ability to specify
DateTimeFormatter
constant names as patterns.This change is NOT fully backwards compatible, since:
DateTimeFormatter.ISO_OFFSET_DATE_TIME
DateTimeFormatter
are not exactly the same as those supported previously byFastDateFormat
When this PR is merged, the major version will need to be bumped due to the backwards incompatibilities.
Therefore, holding off on merging this PR until ready for a new major release.