-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[BOLT] Update Docker to use Ubuntu 24.04 #99421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-bolt Author: Tristan Ross (RossComputerGuy) ChangesUpdates the Dockerfile to use Ubuntu 24.04 due to CMake wanting a newer version. Can be tested by trying to build the Docker image currently in main and then try building the Docker image in this PR. Full diff: https://github.com/llvm/llvm-project/pull/99421.diff 1 Files Affected:
diff --git a/bolt/utils/docker/Dockerfile b/bolt/utils/docker/Dockerfile
index 722a07e46f9e4..c2108f7aec53c 100644
--- a/bolt/utils/docker/Dockerfile
+++ b/bolt/utils/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM ubuntu:20.04 AS builder
+FROM ubuntu:24.04 AS builder
ARG DEBIAN_FRONTEND=noninteractive
ENV TZ=UTC
@@ -26,6 +26,6 @@ RUN mkdir build && \
ninja install-llvm-bolt install-perf2bolt install-merge-fdata \
install-llvm-boltdiff install-bolt_rt
-FROM ubuntu:20.04
+FROM ubuntu:24.04
COPY --from=builder /home/bolt/install /usr/local
|
Updates the Dockerfile to use Ubuntu 24.04 due to CMake wanting a newer version.
aeb0b03
to
bf40039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RossComputerGuy Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Summary: Updates the Dockerfile to use Ubuntu 24.04 due to CMake wanting a newer version. Can be tested by trying to build the Docker image currently in main and then try building the Docker image in this PR. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250719
Updates the Dockerfile to use Ubuntu 24.04 due to CMake wanting a newer version. Can be tested by trying to build the Docker image currently in main and then try building the Docker image in this PR.