[CMake] Options to control generation of reproducers #143037
Conversation
Clang automatically generates a reproducer on crash, but we don't provide any control over the reproducers (whether to generate them only for compiler crashes or linker crashes as well) or their location. This change also additional provides an option to enable generating reproducers in case of an error (and not just crash) which can be helpful in environments such as automated builders to help with reproducing issues.
|
We've had the equivalent in Fuchsia's build and we enable this option on all our builders (including the error reproducers). This has been invaluable and I'd like have the same for our downstream toolchain builders, but I can imagine these might be also helpful for the upstream LLVM builders, especially if we could make the reproducers available as workflow artifacts. |
| CMAKE_C_FLAGS CMAKE_CXX_FLAGS CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) | ||
| endif() | ||
|
|
||
| if(LLVM_ERROR_REPRODUCERS) |
There was a problem hiding this comment.
Can we make this a string-valued cmake option so that setting =always (or other new modes that might come along) doesn't require fresh cmake plumbing?
Not to dissuade you from this patch (which I think is great!), but FWIW, you can set the |
That's what we use for our Clang builders at the moment but we're currently investigating a regression in LLD that only manifests on our Mac builders and results in a crash and we need a way to set The alternative would be to introduce additional environment variables such as |
| endif() | ||
|
|
||
| if(LLVM_CRASH_DIAGNOSTICS_DIR) | ||
| check_c_compiler_flag("-fcrash-diagnostics-dir=foo" SUPPORTS_FCRASH_DIAGNOSTICS_DIR) |
There was a problem hiding this comment.
Is there value in adding a warning here if this is requested but the host compiler does not support the flag?
Clang automatically generates a reproducer on crash, but we don't provide any control over the reproducers (whether to generate them only for compiler crashes or linker crashes as well) or their location. This change also additional provides an option to enable generating reproducers in case of an error (and not just crash) which can be helpful in environments such as automated builders to help with reproducing issues.