[NFC] [clang] fix unused variable warning

[fmayer]

No description provided.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Florian Mayer (fmayer)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/126796.diff

1 Files Affected:

• (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp (+1-1)

diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
index 6452dedb8c391..1411bf1d1c237 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
@@ -156,7 +156,7 @@ bool isConstOwnerPtrMemberExpr(const clang::Expr *E) {
       auto Name = safeGetName(Callee);
       if (Name == "get" || Name == "ptr")
         E = MCE->getImplicitObjectArgument();
-      if (auto *CD = dyn_cast<CXXConversionDecl>(Callee))
+      if (dyn_cast<CXXConversionDecl>(Callee))
         E = MCE->getImplicitObjectArgument();
     }
   } else if (auto *OCE = dyn_cast<CXXOperatorCallExpr>(E)) {

[llvmbot]

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Florian Mayer (fmayer)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/126796.diff

1 Files Affected:

• (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp (+1-1)

diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
index 6452dedb8c391..1411bf1d1c237 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp
@@ -156,7 +156,7 @@ bool isConstOwnerPtrMemberExpr(const clang::Expr *E) {
       auto Name = safeGetName(Callee);
       if (Name == "get" || Name == "ptr")
         E = MCE->getImplicitObjectArgument();
-      if (auto *CD = dyn_cast<CXXConversionDecl>(Callee))
+      if (dyn_cast<CXXConversionDecl>(Callee))
         E = MCE->getImplicitObjectArgument();
     }
   } else if (auto *OCE = dyn_cast<CXXOperatorCallExpr>(E)) {

[steakhal]

I think isa should be preferred if the result of dyncast is not used.
Same applied to the surrounding ifs too.

[steakhal]

Ah, so this one is already merged. Then nvm. It's not worth a followup.

[rniwa]

Oh oops, thank you for the fix. It's odd that the checks didn't catch this before the merge...

[fmayer]

I think isa should be preferred if the result of dyncast is not used. Same applied to the surrounding ifs too.

ad905f1