-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. #120528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rniwa
merged 4 commits into
llvm:main
from
rniwa:detect-protected-this-pattern-lambda-captures
Dec 20, 2024
+128
−2
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,6 +207,58 @@ struct RefCountableWithLambdaCapturingThis { | |
}; | ||
call(lambda); | ||
} | ||
|
||
void method_captures_this_unsafe_capture_local_var_explicitly() { | ||
RefCountable* x = make_obj(); | ||
call([this, protectedThis = RefPtr { this }, x]() { | ||
// expected-warning@-1{{Captured raw-pointer 'x' to ref-counted type or CheckedPtr-capable type is unsafe [webkit.UncountedLambdaCapturesChecker]}} | ||
nonTrivial(); | ||
x->method(); | ||
}); | ||
} | ||
|
||
void method_captures_this_with_other_protected_var() { | ||
RefCountable* x = make_obj(); | ||
call([this, protectedX = RefPtr { x }]() { | ||
// expected-warning@-1{{Captured raw-pointer 'this' to ref-counted type or CheckedPtr-capable type is unsafe [webkit.UncountedLambdaCapturesChecker]}} | ||
nonTrivial(); | ||
protectedX->method(); | ||
}); | ||
} | ||
|
||
void method_captures_this_unsafe_capture_local_var_explicitly_with_deref() { | ||
RefCountable* x = make_obj(); | ||
call([this, protectedThis = Ref { *this }, x]() { | ||
// expected-warning@-1{{Captured raw-pointer 'x' to ref-counted type or CheckedPtr-capable type is unsafe [webkit.UncountedLambdaCapturesChecker]}} | ||
nonTrivial(); | ||
x->method(); | ||
}); | ||
} | ||
|
||
void method_captures_this_unsafe_local_var_via_vardecl() { | ||
RefCountable* x = make_obj(); | ||
auto lambda = [this, protectedThis = Ref { *this }, x]() { | ||
// expected-warning@-1{{Captured raw-pointer 'x' to ref-counted type or CheckedPtr-capable type is unsafe [webkit.UncountedLambdaCapturesChecker]}} | ||
nonTrivial(); | ||
x->method(); | ||
}; | ||
call(lambda); | ||
} | ||
|
||
void method_captures_this_with_guardian() { | ||
auto lambda = [this, protectedThis = Ref { *this }]() { | ||
nonTrivial(); | ||
}; | ||
call(lambda); | ||
} | ||
|
||
void method_captures_this_with_guardian_refPtr() { | ||
auto lambda = [this, protectedThis = RefPtr { &*this }]() { | ||
nonTrivial(); | ||
}; | ||
call(lambda); | ||
} | ||
|
||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rniwa I'm running into the following crash when I run this test locally:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh oops, fixed! |
||
|
||
struct NonRefCountableWithLambdaCapturingThis { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests where the Arg isn't
this
and forUO_AddrOf
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, & case is a bit silly because it's
&*this
but added anyway.