[Clang] Implement CWG 2628 "Implicit deduction guides should propagate constraints" #111143
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -479,6 +479,169 @@ A a{.f1 = {1}}; | ||
|
|
||
| } // namespace GH83368 | ||
|
|
||
| namespace GH60777 { | ||
|
|
||
| template <typename... Ts> constexpr bool True() { return true; } | ||
|
|
||
| template <typename T> | ||
| requires(sizeof(T) > 1) | ||
| struct A { | ||
| template <typename... Ts> | ||
| requires(sizeof...(Ts) == 0) | ||
| A(T val, Ts... tail) | ||
| requires(True<Ts...>()) | ||
| {} | ||
| }; | ||
|
|
||
| A a(42); | ||
|
|
||
| // `requires (sizeof(T) > 1)` goes into the deduction guide together with | ||
| // `requires (True<Ts...>())`, while `requires(sizeof...(Ts) == 0)` goes into | ||
| // the template parameter list of the synthesized declaration. | ||
|
|
||
| // CHECK-LABEL: Dumping GH60777::<deduction guide for A>: | ||
| // CHECK-NEXT: FunctionTemplateDecl 0x{{.+}} <{{.+}}> {{.+}} implicit <deduction guide for A> | ||
| // CHECK-NEXT: |-TemplateTypeParmDecl 0x{{.+}} <{{.+}}> col:20 referenced typename depth 0 index 0 T | ||
| // CHECK-NEXT: |-TemplateTypeParmDecl 0x{{.+}} <{{.+}}> col:25 typename depth 0 index 1 ... Ts | ||
| // CHECK-NEXT: |-ParenExpr 0x{{.+}} <{{.+}}> 'bool' | ||
| // CHECK-NEXT: | `-BinaryOperator 0x{{.+}} <{{.+}}> 'bool' '==' | ||
| // CHECK-NEXT: | |-SizeOfPackExpr {{.+}} Ts | ||
| // CHECK-NEXT: | | `-TemplateArgument type 'Ts...':'type-parameter-0-1...' | ||
| // CHECK-NEXT: | | `-PackExpansionType 0x{{.+}} 'Ts...' dependent | ||
| // CHECK-NEXT: | | `-TemplateTypeParmType 0x{{.+}} 'Ts' dependent contains_unexpanded_pack depth 0 index 1 pack | ||
| // CHECK-NEXT: | | `-TemplateTypeParm 0x{{.+}} 'Ts' | ||
| // CHECK-NEXT: | `-ImplicitCastExpr {{.+}} <IntegralCast> | ||
| // CHECK-NEXT: | `-IntegerLiteral 0x{{.+}} <{{.+}}> 'int' 0 | ||
| // CHECK-NEXT: |-CXXDeductionGuideDecl 0x{{.+}} <{{.+}}> line:{{.+}} implicit <deduction guide for A> 'auto (T, Ts...) -> A<T>' | ||
| // CHECK-NEXT: | |-ParmVarDecl 0x{{.+}} <{{.+}}> col:{{.+}} val 'T' | ||
| // CHECK-NEXT: | |-ParmVarDecl 0x{{.+}} <{{.+}}> col:{{.+}} tail 'Ts...' pack | ||
| // CHECK-NEXT: | `-BinaryOperator 0x{{.+}} <{{.+}}> 'bool' '&&' | ||
| // CHECK-NEXT: | |-ParenExpr 0x{{.+}} <{{.+}}> 'bool' | ||
| // CHECK-NEXT: | | `-BinaryOperator 0x{{.+}} <{{.+}}> 'bool' '>' | ||
| // CHECK-NEXT: | | |-UnaryExprOrTypeTraitExpr {{.+}} sizeof 'T' | ||
| // CHECK-NEXT: | | `-ImplicitCastExpr {{.+}} <IntegralCast> | ||
| // CHECK-NEXT: | | `-IntegerLiteral 0x{{.+}} <{{.+}}> 'int' 1 | ||
| // CHECK-NEXT: | `-ParenExpr 0x{{.+}} <{{.+}}> '<dependent type>' | ||
| // CHECK-NEXT: | `-CallExpr 0x{{.+}} <{{.+}}> '<dependent type>' | ||
| // CHECK-NEXT: | `-UnresolvedLookupExpr 0x{{.+}} <col:14, col:24> '<dependent type>' {{.+}} | ||
| // CHECK-NEXT: | `-TemplateArgument type 'Ts...':'type-parameter-0-1...' | ||
| // CHECK-NEXT: | `-PackExpansionType 0x{{.+}} 'Ts...' dependent | ||
| // CHECK-NEXT: | `-TemplateTypeParmType 0x{{.+}} 'Ts' dependent contains_unexpanded_pack depth 0 index 1 pack | ||
| // CHECK-NEXT: | `-TemplateTypeParm 0x{{.+}} 'Ts' | ||
|
|
||
| template <typename T> | ||
| struct B { | ||
| template <typename... Ts> | ||
| B(T val, Ts... tail) | ||
| requires(True<tail...>()) | ||
| {} | ||
| }; | ||
|
|
||
| B b(42, 43); | ||
| // expected-error@-1 {{no viable constructor}} \ | ||
| // expected-note@-6 {{constraints not satisfied}} \ | ||
| // expected-note@-5 {{because substituted constraint expression is ill-formed}} \ | ||
| // expected-note@-6 {{implicit deduction guide declared as 'template <typename T, typename ...Ts> B(T val, Ts ...tail) -> B<T> requires (True<tail...>())'}} \ | ||
| // expected-note@-8 {{function template not viable}} \ | ||
| // expected-note@-8 {{implicit deduction guide declared as 'template <typename T> B(B<T>) -> B<T>'}} | ||
|
|
||
| } // namespace GH60777 | ||
|
|
||
| // Examples from @hokein. | ||
| namespace GH98592 { | ||
|
|
||
| template <class T> concept True = true; | ||
| double arr3[3]; | ||
|
|
||
| template <class T> | ||
| struct X { | ||
| const int size; | ||
| template <class U> | ||
| constexpr X(T, U(&)[3]) requires True<T> : size(sizeof(T)) {} | ||
| }; | ||
|
|
||
| template <typename T, typename U> | ||
| X(T, U (&)[3]) -> X<U>; | ||
|
|
||
| constexpr X x(3, arr3); | ||
|
|
||
| // The synthesized deduction guide is more constrained than the explicit one. | ||
| static_assert(x.size == 4); | ||
|
|
||
| // CHECK-LABEL: Dumping GH98592::<deduction guide for X>: | ||
| // CHECK-NEXT: FunctionTemplateDecl 0x{{.+}} <{{.+}}> col:13 implicit <deduction guide for X> | ||
| // CHECK-NEXT: |-TemplateTypeParmDecl 0x{{.+}} <{{.+}}> col:17 referenced class depth 0 index 0 T | ||
| // CHECK-NEXT: |-TemplateTypeParmDecl 0x{{.+}} <{{.+}}> col:19 class depth 0 index 1 U | ||
| // CHECK-NEXT: |-CXXDeductionGuideDecl 0x{{.+}} <{{.+}}> col:13 implicit <deduction guide for X> 'auto (T, U (&)[3]) -> X<T>' | ||
| // CHECK-NEXT: | |-ParmVarDecl 0x{{.+}} <col:15> col:16 'T' | ||
| // CHECK-NEXT: | |-ParmVarDecl 0x{{.+}} <col:18, col:24> col:21 'U (&)[3]' | ||
| // CHECK-NEXT: | `-ConceptSpecializationExpr 0x{{.+}} <col:36, col:42> 'bool' Concept 0x{{.+}} 'True' | ||
| // CHECK-NEXT: | |-ImplicitConceptSpecializationDecl 0x{{.+}} <{{.+}}> col:28 | ||
| // CHECK-NEXT: | | `-TemplateArgument type 'type-parameter-0-0' | ||
| // CHECK-NEXT: | | `-TemplateTypeParmType 0x{{.+}} 'type-parameter-0-0' dependent depth 0 index 0 | ||
| // CHECK-NEXT: | `-TemplateArgument <{{.+}}> type 'T':'type-parameter-0-0' | ||
| // CHECK-NEXT: | `-TemplateTypeParmType 0x{{.+}} 'T' dependent depth 0 index 0 | ||
| // CHECK-NEXT: | `-TemplateTypeParm 0x{{.+}} 'T' | ||
| // CHECK-NEXT: `-CXXDeductionGuideDecl 0x{{.+}} <col:3, col:63> col:13 implicit used <deduction guide for X> 'auto (int, double (&)[3]) -> GH98592::X<int>' implicit_instantiation | ||
| // CHECK-NEXT: |-TemplateArgument type 'int' | ||
| // CHECK-NEXT: | `-BuiltinType 0x{{.+}} 'int' | ||
| // CHECK-NEXT: |-TemplateArgument type 'double' | ||
| // CHECK-NEXT: | `-BuiltinType 0x{{.+}} 'double' | ||
| // CHECK-NEXT: |-ParmVarDecl 0x{{.+}} <col:15> col:16 'int' | ||
| // CHECK-NEXT: |-ParmVarDecl 0x{{.+}} <col:18, col:24> col:21 'double (&)[3]' | ||
| // CHECK-NEXT: `-ConceptSpecializationExpr 0x{{.+}} <col:36, col:42> 'bool' Concept 0x{{.+}} 'True' | ||
| // CHECK-NEXT: |-ImplicitConceptSpecializationDecl 0x{{.+}} <{{.+}}> col:28 | ||
| // CHECK-NEXT: | `-TemplateArgument type 'type-parameter-0-0' | ||
| // CHECK-NEXT: | `-TemplateTypeParmType 0x{{.+}} 'type-parameter-0-0' dependent depth 0 index 0 | ||
| // CHECK-NEXT: `-TemplateArgument <{{.+}}> type 'T':'type-parameter-0-0' | ||
| // CHECK-NEXT: `-TemplateTypeParmType 0x{{.+}} 'T' dependent depth 0 index 0 | ||
| // CHECK-NEXT: `-TemplateTypeParm 0x{{.+}} 'T' | ||
|
|
||
| template <class T> requires True<T> struct Y { | ||
| const int size; | ||
| template <class U> | ||
| constexpr Y(T, U(&)[3]) : size(sizeof(T)) {} | ||
| }; | ||
|
|
||
| template <typename T, typename U> Y(T, U (&)[3]) -> Y<U>; | ||
|
|
||
| constexpr Y y(3, arr3); | ||
|
|
||
| // Likewise, the synthesized deduction guide should be preferred | ||
| // according to [over.match.class.deduct]p1. | ||
| static_assert(y.size == 4); | ||
|
Comment on lines
+600
to
+612
There was a problem hiding this comment. Though been discussed in #98592, it's still not so clear to me as to whether this case should be accepted: While the wording from [over.match.class.deduct]p1.1.2 suggests the constraint of the synthesized CTAD is the conjunction of that of C and that of the constructor, the note there also seems to imply the constraint from C should be checked before the checking of the constraint of constructor, so this example should not compile that way. (The overload resolution would pick up the explicit CTAD guide if C's required-clause were not propagated into the implicit CTAD guide.) I still build up a && operator for the literal "conjunction" currently, but I think I can remove that if our reading is wrong. There was a problem hiding this comment. I'm trying to figure if the order of operation is observable - I don't think so, so I am confused by the note @erichkeane There was a problem hiding this comment. This looks ambiguous to me FWIW. They USE conjunction, but my reading doesn't make it mean the same as elsewhere (for the purposes of subsumption). I THINK it is just supposed to mean "all of them are checked for this deduction guide", but I'd like to hear from CWG/see what a CWG reflector conversation says. There was a problem hiding this comment. (Also tagging @zygoloid who added that note https://cplusplus.github.io/CWG/issues/2714.html) There was a problem hiding this comment. I filed cplusplus/draft#7300 and hopefully we can get an answer there. There was a problem hiding this comment.
As has been explained there, the use of "conjunction" indicates a conjunction form of the constraints and therefore it should participate in overload resolution. |
||
|
|
||
| // Dumping GH98592::<deduction guide for Y>: | ||
| // FunctionTemplateDecl 0x{{.+}} <{{.+}}> col:13 implicit <deduction guide for Y> | ||
| // |-TemplateTypeParmDecl 0x{{.+}} <{{.+}}> col:17 referenced class depth 0 index 0 T | ||
| // |-TemplateTypeParmDecl 0x{{.+}} <{{.+}}> col:19 class depth 0 index 1 U | ||
| // |-CXXDeductionGuideDecl 0x{{.+}} <{{.+}}> col:13 implicit <deduction guide for Y> 'auto (T, U (&)[3]) -> Y<T>' | ||
| // | |-ParmVarDecl 0x{{.+}} <col:15> col:16 'T' | ||
| // | |-ParmVarDecl 0x{{.+}} <col:18, col:24> col:21 'U (&)[3]' | ||
| // | `-ConceptSpecializationExpr 0x{{.+}} <{{.+}}> 'bool' Concept 0x{{.+}} 'True' | ||
| // | |-ImplicitConceptSpecializationDecl 0x{{.+}} <{{.+}}> col:28 | ||
| // | | `-TemplateArgument type 'type-parameter-0-0' | ||
| // | | `-TemplateTypeParmType 0x{{.+}} 'type-parameter-0-0' dependent depth 0 index 0 | ||
| // | `-TemplateArgument <{{.+}}> type 'T':'type-parameter-0-0' | ||
| // | `-TemplateTypeParmType 0x{{.+}} 'T' dependent depth 0 index 0 | ||
| // | `-TemplateTypeParm 0x{{.+}} 'T' | ||
| // `-CXXDeductionGuideDecl 0x{{.+}} <{{.+}}> col:13 implicit used <deduction guide for Y> 'auto (int, double (&)[3]) -> GH98592::Y<int>' implicit_instantiation | ||
| // |-TemplateArgument type 'int' | ||
| // | `-BuiltinType 0x{{.+}} 'int' | ||
| // |-TemplateArgument type 'double' | ||
| // | `-BuiltinType 0x{{.+}} 'double' | ||
| // |-ParmVarDecl 0x{{.+}} <col:15> col:16 'int' | ||
| // |-ParmVarDecl 0x{{.+}} <col:18, col:24> col:21 'double (&)[3]' | ||
| // `-ConceptSpecializationExpr 0x{{.+}} <{{.+}}> 'bool' Concept 0x{{.+}} 'True' | ||
| // |-ImplicitConceptSpecializationDecl 0x{{.+}} <{{.+}}> col:28 | ||
| // | `-TemplateArgument type 'type-parameter-0-0' | ||
| // | `-TemplateTypeParmType 0x{{.+}} 'type-parameter-0-0' dependent depth 0 index 0 | ||
| // `-TemplateArgument <{{.+}}> type 'T':'type-parameter-0-0' | ||
| // `-TemplateTypeParmType 0x{{.+}} 'T' dependent depth 0 index 0 | ||
| // `-TemplateTypeParm 0x{{.+}} 'T' | ||
|
|
||
| } // namespce GH98592 | ||
|
|
||
| namespace GH122134 { | ||
|
|
||
| template <class, class> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A heads-up: we're encountering clang crashes on this assertion. I'm working on a minimal reproducer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #128691.