Skip to content

[alpha.webkit.UncountedCallArgsChecker] Use canonical type #109393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
+33 −5
Merged

[alpha.webkit.UncountedCallArgsChecker] Use canonical type #109393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
View file
Original file line number Diff line number Diff line change
@@ -155,7 +155,7 @@ std::optional<bool> isUncounted(const QualType T) {
std::optional<bool> isUncounted(const CXXRecordDecl* Class)
{
// Keep isRefCounted first as it's cheaper.
if (isRefCounted(Class))
if (!Class || isRefCounted(Class))
return false;

std::optional<bool> IsRefCountable = isRefCountable(Class);
9 changes: 5 additions & 4 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp
View file
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ class UncountedCallArgsChecker
return;
}
auto *E = MemberCallExpr->getImplicitObjectArgument();
QualType ArgType = MemberCallExpr->getObjectType();
QualType ArgType = MemberCallExpr->getObjectType().getCanonicalType();
std::optional<bool> IsUncounted = isUncounted(ArgType);
if (IsUncounted && *IsUncounted && !isPtrOriginSafe(E))
reportBugOnThis(E);
@@ -102,12 +102,13 @@ class UncountedCallArgsChecker
// if ((*P)->hasAttr<SafeRefCntblRawPtrAttr>())
// continue;

const auto *ArgType = (*P)->getType().getTypePtrOrNull();
if (!ArgType)
QualType ArgType = (*P)->getType().getCanonicalType();
const auto *TypePtr = ArgType.getTypePtrOrNull();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTypePtrOrNull() is unnecessary most of the time because you can do all the same operations on QualType directly, thanks to the overloaded QualType::operator->().

I think isUncountedPtr() should simply accept a QualType directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Let me make that change in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#110213

if (!TypePtr)
continue; // FIXME? Should we bail?

// FIXME: more complex types (arrays, references to raw pointers, etc)
std::optional<bool> IsUncounted = isUncountedPtr(ArgType);
std::optional<bool> IsUncounted = isUncountedPtr(TypePtr);
if (!IsUncounted || !(*IsUncounted))
continue;

27 changes: 27 additions & 0 deletions clang/test/Analysis/Checkers/WebKit/uncounted-obj-const-v-muable.cpp
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s

#include "mock-types.h"

class Object {
public:
void ref() const;
void deref() const;

bool constFunc() const;
void mutableFunc();
};

class Caller {
void someFunction();
void otherFunction();
private:
RefPtr<Object> m_obj;
};

void Caller::someFunction()
{
m_obj->constFunc();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
m_obj->mutableFunc();
// expected-warning@-1{{Call argument for 'this' parameter is uncounted and unsafe}}
}
Loading