"No expected directives found" error message is confusing if -verify=foo was passed

[tbaederr]

If one passes -verify=foo, the error message when no foo-* directives are found is:

error: no expected directives found: consider use of 'expected-no-diagnostics'

however, what's meant here is not expected-no-diagnostics but of course foo-no-diagnostics. This is especially confusing if multiple compiler invocations with different -verify= values are present.

The error message should use the proper prefix.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

[llvmbot]

@llvm/issue-subscribers-clang-driver

[diohabara]

Hi! Let me resolve this issue!

[diohabara]

I'm still working on it!
I successfully reproduced the issue, and I'll fix it.

[diohabara]

@tbaederr
According to this commit( 0fea045 ), it seems that the behavior is expected. Should we fix it to err with foo-no-diagnostics?

[tbaederr]

It's fine that a "no-diagnostics" comment is required, but if I pass -verify=foo, I must use "foo-no-diagnostics" and as such, it would be nice if error messages about the usage of such "expected" messages would use the proper prefix and tell me that I should be adding a "foo-no-diagnostics" comment, not an "expected-no-diagnostics" one.

[diohabara]

It's fine that a "no-diagnostics" comment is required, but if I pass -verify=foo, I must use "foo-no-diagnostics" and as such, it would be nice if error messages about the usage of such "expected" messages would use the proper prefix and tell me that I should be adding a "foo-no-diagnostics" comment, not an "expected-no-diagnostics" one.

Thanks, I see! Since the commit I mentioned said that expected-no-diagnostics was expected behavior, I was wondering if I were in the right direction.

[tbaederr]

I don't think "expected-no-diagnostics" is to be taken literally; it's just the default when no -verify= is passed.

[Unique-Usman]

Hello, has this issue been fixed and @diohabara are you still working on this, I will like to work on it.

[diohabara]

@Unique-Usman

Yes, you can do it.

[Sh0g0-1758]

Hello, I think that this issue has not been resolved yet. @tbaederr , I would like to work on this issue, can you please assign it to me.

[Sh0g0-1758]

I reproduced the error by reading the following documentation : docs. Will rectify it now.

[Sh0g0-1758]

I have made the necessary changes in the DiagnosticFrontendKinds.td file as :

def err_verify_no_directives : Error<
    "no expected directives found: consider use of '%0'-no-diagnostics">;

and in VerifyDiagnosticConsumer.cpp as :

if (SrcManager) {
// Produce an error if no expected-* directives could be found in the
// source file(s) processed.
if (Status == HasNoDirectives) {
  Diags.Report(diag::err_verify_no_directives).AddString(TO DO : ADD DIAGNOSTIC NAME).setForceEmit();
  ++NumErrors;
  Status = HasNoDirectivesReported;
}

can you please confirm whether or not I can get this by SM.getDiagnostics() ?

@tbaederr

[tbaederr]

You might wanna look at b4e0589, which did something similar.

[Sh0g0-1758]

@tbaederr, created a PR for the same. Please take a look at it and suggest changes when you get free. Also really sorry for the delay, was busy the past couple of days.