[CIR] incorrect global view index and offset when neg index #795
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixed signed and unsigned integer operator cause difference result when index of array is negative
Lancern
requested changes
Aug 18, 2024
bcardosolopes
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Thanks for your first PR, very nice! @Lancern thanks for review.
Almost good, just some nit for completeness!
bcardosolopes
approved these changes
Aug 22, 2024
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
mixed signed and unsigned integer operator cause difference result when index of array is negative
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
mixed signed and unsigned integer operator cause difference result when index of array is negative
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
mixed signed and unsigned integer operator cause difference result when index of array is negative
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
mixed signed and unsigned integer operator cause difference result when index of array is negative
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
mixed signed and unsigned integer operator cause difference result when index of array is negative
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
mixed signed and unsigned integer operator cause difference result when index of array is negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mixed signed and unsigned integer operator cause difference result when index of array is negative