-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][HIP|CUDA] Generate global storing CUDA|HIP stub function #1341
Conversation
ae7074f
to
432d4f8
Compare
This PR suggests we should use the function names, rather than the FuncOp itself, as the key to |
Ok, I will add this. |
432d4f8
to
98de2c5
Compare
98de2c5
to
1b14d85
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit but otherwise ready to go
On HIP when launching a kernel we pass as a first argument a global variable that points to the device stub function.
We follow OG design by having a map that pairs globals to symbols. In CUDA this is effectively a nop, as CUDA passes the device stub as a first argument.