[CIR][CIRGen] Enable comdat for static variables #1015
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeenai
requested changes
Oct 29, 2024
Comment on lines
3
to
6
| // RUN: %clang_cc1 -triple aarch64-none-linux-android24 -fclangir -emit-cir %s -o %t1.cir | ||
| // RUN: FileCheck --check-prefix=CIR-AARCH64 --input-file=%t1.cir %s | ||
| // RUN: %clang_cc1 -triple aarch64-none-linux-android24 -fclangir -emit-llvm %s -o %t1.ll | ||
| // RUN: FileCheck --check-prefix=LLVM-AARCH64 --input-file=%t1.ll %s |
There was a problem hiding this comment.
Do we need this to be AArch64-specific, or can we just reuse the existing RUN lines?
There was a problem hiding this comment.
No, no need for comdat, I was just thinking to prepare for future target-dependent features testing in this file. But probably we should wait until that comes.
Comment on lines
43
to
52
| class b { | ||
| public: | ||
| // CIR-AARCH64-DAG: cir.global linkonce_odr comdat @_ZZN1b4testEvE1c = #cir.int<0> : !s32i | ||
|
|
||
| // LLVM-AARCH64-DAG: $_ZZN1b4testEvE1c = comdat any | ||
| // LLVM-AARCH64-DAG: @_ZZN1b4testEvE1c = linkonce_odr global i32 0, comdat, align 4 | ||
| void test() { static int c; } | ||
| // CIR-AARCH64-LABEL: @_ZN1b4testEv | ||
| // CIR-AARCH64: {{%.*}} = cir.get_global @_ZZN1b4testEvE1c : !cir.ptr<!s32i> | ||
| }; |
There was a problem hiding this comment.
Just an static inside an inline function should do the trick: https://godbolt.org/z/8anK6G9x5
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.