-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: Always use %
for getting intrinsics
#100
base: main
Are you sure you want to change the base?
[Refactor]: Always use %
for getting intrinsics
#100
Conversation
%
for getting intrinsics%
for getting intrinsics
61c4ead
to
945e629
Compare
What's the benefit here? If everything in this package uses |
There is in the test files. |
True. What's the benefit of this change tho? |
The benefit is consistency and making it possible to deprecate the non‑ |
I'm not sure why we'd want to deprecate it? callBound is the newest helper, and I intentionally left off the |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 91.03% 91.01% -0.02%
==========================================
Files 647 647
Lines 8931 9031 +100
Branches 2109 2150 +41
==========================================
+ Hits 8130 8220 +90
- Misses 801 811 +10
Continue to review full report at Codecov.
|
Depending on the progression of https://github.com/ljharb/proposal-get-intrinsic - in which I'm planning to not require the |
No description provided.