WIP: Try adding guest user library #3
Conversation
m4ra
force-pushed
the
jp-2502-guest-accounts
branch
from
c3e2c5d to
dc4a661
Compare
|
@partizipation @goapunk to enable the guest user from the registration form, I would add the maybe_make_guest_user in the a+ DefaultSingUpForm.save(). |
|
@partizipation the signup template to add the login as guest button is here. But I think the registration form is in a separate story. |
|
|
||
| GUEST_USER = { | ||
| "NAME_GENERATOR": "guest_user.functions.generate_uuid_username", # Default option | ||
| } |
There was a problem hiding this comment.
I changed this in the fork of the django-guest, because the long uuid appears on the menu tab and it's ugly. So I switched to the numbered version. But maybe we deploy this one, and PM can let us know.
| {% url 'guest_create' as guest_create_url %} | ||
| {% with next_param=request.GET.next %} | ||
| {% with guest_url=guest_create_url|add:"?next="|add:next_param %} | ||
| <p>{% blocktranslate %}Sie wollen als Gast fortfahren? Dann klicken Sie <a href="{{ guest_url }}">hier</a>.{% endblocktranslate %}</p> |
There was a problem hiding this comment.
We need the english version here.
There was a problem hiding this comment.
Asked Janek for english text yesterday, so waiting to add the content of these pages until I have that and can just do everything at once
| {% with next_param=request.GET.next %} | ||
| {% with guest_url=guest_create_url|add:"?next="|add:next_param %} | ||
| <p> | ||
| {% blocktranslate %}Sie wollen als Gast fortfahren? Dann klicken Sie |
| <button class="btn btn--primary btn--secondary-filled" type="submit">{% translate "Continue as Guest" %}</button> | ||
| </div> | ||
| </form> | ||
| {% endblock content %} |
There was a problem hiding this comment.
Why not add the guest part in the signup template?
There was a problem hiding this comment.
You mean go ahead and add the rest of what's in designs, or are you talking about structuring this differently and making accounts/signup.html multipurpose? or something else
partizipation
force-pushed
the
jp-2502-guest-accounts
branch
from
391ad52 to
2ed7317
Compare
we decided to fork django-guest-user and add email and password for the guest authentication. See here
Couldn't get around the circular reference, tried a bunch of things. Code has a bunch of commented out attempts so it's a little messy but maybe this PR helps review.Tried: