Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix follow issues #6254

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix follow issues #6254

merged 1 commit into from
Mar 10, 2025

Conversation

hom3mad3
Copy link
Contributor

fixes: #6085 and #6084

@hom3mad3 hom3mad3 requested a review from vellip March 10, 2025 11:53
@hom3mad3
Copy link
Contributor Author

hom3mad3 commented Mar 10, 2025

@vellip decided to not overwrite spacings above the alert, as to not affect the elements below. it was already enough work to get the alert outside the container 🙃 we can probably handle this after release if necessary

also, ended up not using a custom class, but left the enhancement in a4 anyways, since i think giving the option for custom classes follows best practice.

@hom3mad3 hom3mad3 force-pushed the mr-2025-03-fix-follow branch from 42bc0b1 to 1502997 Compare March 10, 2025 12:11
Copy link
Collaborator

@vellip vellip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very kewl, thank you!

@hom3mad3 hom3mad3 merged commit 7ca67f1 into dev Mar 10, 2025
2 checks passed
@hom3mad3 hom3mad3 deleted the mr-2025-03-fix-follow branch March 10, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants