Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry install complaining not a git project #33

Closed
cmungall opened this issue Dec 13, 2022 · 3 comments · Fixed by #41
Closed

poetry install complaining not a git project #33

cmungall opened this issue Dec 13, 2022 · 3 comments · Fixed by #41

Comments

@cmungall
Copy link
Member

image
@noelmcloughlin noelmcloughlin mentioned this issue Jan 15, 2023
Closed
@noelmcloughlin noelmcloughlin mentioned this issue Jan 25, 2023
Merged
@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Jan 26, 2023 •
edited
Loading

I created a new project from scratch using this cookiecutter and I could not reproduce this error. Could this be a old poetry version issue?

The reason I ask is the PRs associated to fix this issue seem like solving an unreproducible issue.

@StroemPhi
Copy link

I just encountered the same error, when setting up a new repo from scratch according to the readme and also had to git initin order to be able to run make setup.

@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Feb 6, 2023 •
edited
Loading

Thank you for confirming @StroemPhi ! Closing via #38

@hrshdhgd hrshdhgd closed this as completed Feb 6, 2023
@noelmcloughlin noelmcloughlin mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(makefile): keep git repo, needed in step 8
3 participants
@cmungall @hrshdhgd @StroemPhi