Skip to content

.env.public approach to Makefile variables: quotes are literal in GNU Make #106

Closed
@zmughal

Description

@zmughal

If the .env.public file is meant to be used as both a source-able .env file and as Makefile variables, it must use the intersection of their syntaxes which is stricter on special characters. For GNU Make, this means that any quotes (m/["']/) will be literal quotes in the GNU Make variable, but sh(1) will use the contents of the quoted string.

It might be better to treat it as just Makefile variables (e.g., config.Makefile) and apply the appropriate quoting in the GNU Make recipe commands.

Full details mentioned here: #95 (comment) (with a patch I do not like).

Activity

noelmcloughlin

noelmcloughlin commented on Apr 9, 2024

@noelmcloughlin
Contributor

Hi @zmughal Sorry for delay. I think we could just do a PR to remove quotes from https://github.com/linkml/linkml-project-cookiecutter/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.env.public
They are not necessary for source-able .env file

zmughal

zmughal commented on Dec 26, 2024

@zmughal
Author

I believe that this can be closed via #123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @zmughal@sierra-moxon@noelmcloughlin

        Issue actions

          `.env.public` approach to `Makefile` variables: quotes are literal in GNU Make · Issue #106 · linkml/linkml-project-cookiecutter