🐛 Fix duplicated key issue #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwingt
approved these changes
Nov 23, 2022
| @@ -371,10 +371,10 @@ export default { | |||
| const historyInDB = data.list; | |||
| const eventMap = new Map(); | |||
| historyOnChain.forEach(e => { | |||
| eventMap.set(`${e.txHash}-${e.nftId}`, e); | |||
| eventMap.set(`${e.txHash}-${e.nftId}-${e.event}`, e); | |||
There was a problem hiding this comment.
Do we really want to key each event, or do we just want message keys?
If its just message maybe msg_index will do
There was a problem hiding this comment.
So, the key would be {txHash}-{msgIndex}?
There was a problem hiding this comment.
In what case do we have
mint_nftandnew_classin a same transaction? It sounds impossible since we don't have aclass_idformint_nftifnew_classis not passed as a transaction first..
Sorry for typo, should be mint_nft and /cosmos.nft.v1beta1.MsgSend, not new_class.
There was a problem hiding this comment.
Oh I looked again and the event api only returns event name not msg_index
So current event key is good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we may have
mint_nftandnew_classevents in the same Tx.The key should be multiple fields.