Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currencyrate: switch to new coindesk api #651

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

daywalker90
Copy link
Contributor

The old coindesk api is no longer working. I'm not sure this is the best index but the values seem in line with the other sources.

@daywalker90 daywalker90 force-pushed the currencyrate-coindesk-api branch from fc34a25 to 51c2046 Compare February 23, 2025 10:14
@chrisguida
Copy link
Collaborator

This appears to fix the CI failure here on line 1560:

pyln.client.lightning.RpcError: RPC call failed: method: currencyrates, payload: ['USD'], error: {'code': -32600, 'message': 'Error while processing currencyrates: HTTPSConnectionPool(host=\'api.coindesk.com\', port=443): Max retries exceeded with url: /v1/bpi/currentprice/USD.json (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7f9012cdaf00>: Failed to resolve \'api.coindesk.com\' ([Errno -5] No address associated with hostname)"))', .

ACK 51c2046

Thanks for the fix @daywalker90 !!

@chrisguida chrisguida merged commit 45a1134 into lightningd:master Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants