This repository was archived by the owner on Jul 21, 2023. It is now read-only.
Fix: favour providers peerInfo over sender peerInfo in ADD_PROVIDER #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
approved these changes
May 31, 2019
There was a problem hiding this comment.
This looks good. We should create an issue to track the removal of this code and attach that to the IPFS dht enabled by default roll out. There are also some old api TODOs in the codebase that are marked for deprecation in "newer" versions that have already happened. I think we should do those as a part of this issue as well. cc: @vasco-santos
|
@jacobheun I will create that issue and discuss there! But shortly, my idea was to remove those TODO's (from deprecations at least) when we move to async iterators. That way, people using older APIs will only need to change once. |
|
Ah yeah, that would be a better time to switch, good call. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128