-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix view learn device regression #13138
base: develop
Are you sure you want to change the base?
Fix view learn device regression #13138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested things out locally and things worked as expected. Overall, the code changes LGTM so once the tests are fixed up should be good to go.
kolibri/plugins/coach/assets/src/views/common/ReportsControls.vue
Outdated
Show resolved
Hide resolved
Build Artifacts
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ozer550 - I think you're on the right track here, but there are a few adjustments needed to stay fully in line with the original intention of the issue/fix. I know some of the different learner setups can be complicated, so let me know if you want to discuss the scenarios more! I think it might make more sense once you can fully wrap your mind around picturing what this could look like in a classroom
Summary
lod-link-fix.mp4
References
closes #12947
Reviewer guidance
Observe that in the main exam page, and when clicking into a specific exam, see that the "View learner devices" link (and link to that page) is absent.