Create task for initial device provisioning #13102
Conversation
github-actions
bot
added
DEV: backend
Build Artifacts
|
| throw new Error('Device provisioning task not found'); | ||
| } | ||
| if (task.status === TaskStatuses.COMPLETED) { | ||
| const facilityId = task.result.facility_id; |
There was a problem hiding this comment.
Add this to the extra_metadata instead, rather than updating the API endpoint to return result.
kolibri/core/tasks/api.py
Outdated
| @@ -100,6 +100,7 @@ def _job_to_response(self, job): | |||
| "args": job.args, | |||
| "kwargs": job.kwargs, | |||
| "extra_metadata": job.extra_metadata, | |||
| "result": job.result, | |||
There was a problem hiding this comment.
Let's not add this, and just utilize extra_metadata instead.
| provision_device(**provisioning_data) | ||
|
|
||
| schedule_ping() # Trigger telemetry pingback after we've provisioned | ||
|
|
There was a problem hiding this comment.
job = get_current_job()
if job:
job.update_metadata(facility_id=facility.id)
| self.client.get(initialize_url) | ||
| data = self._default_provision_data() | ||
| del data["superuser"] | ||
| data.update({"auth_token": "test"}) |
There was a problem hiding this comment.
@rtibbles with the new task implementation, I am not handling this case. Should we do it?
There was a problem hiding this comment.
Yes, we want to make sure that after the task is run, the osuser is properly assigned.
|
Thanks @rtibbles! I have updated the PR using the |
|
Hi @AlexVelezLl, when testing the setup flows between 2 Ubuntu VMs, everything is working correctly.
onmyown.webmLogs: onmyownlogs.zip and on-my-own-logcat.txt
Here are the Ubuntu server logs, in case you need those too: server-logs.zip |
Summary
Note: Welcome modal for LOD and on my own devices not appearing is not a regression from this PR, and its probably related to the same cause as #13071
References
Closes #12753
Reviewer guidance
Play with the setup wizard and check that the device is successfully provisioned for all its variants